Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda): cannot use latest version in multiple cloudfront distributions #9966

Merged
merged 4 commits into from
Aug 26, 2020

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Aug 25, 2020

The error produced is around construct collision, i.e., "There is
already a Construct with name '$LATEST'".

The fix is to cache the latest version on the instance.

fixes #4459


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@nija-at nija-at requested a review from a team August 25, 2020 15:15
@nija-at nija-at self-assigned this Aug 25, 2020
@nija-at nija-at marked this pull request as draft August 25, 2020 15:15
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 25, 2020
…utions

The error produced is around construct collision, i.e., "There is
already a Construct with name '$LATEST' in Function".

The fix is to cache the latest version on the instance.

fixes #4459
@nija-at nija-at force-pushed the nija-at/lambda-latestversion-cache branch from 1fb2c04 to 898f4cd Compare August 25, 2020 15:16
@nija-at nija-at marked this pull request as ready for review August 25, 2020 15:17
@nija-at nija-at changed the title fix(lambda): cannot use latest version in multiple CloudFront distributions fix(lambda): cannot use latest version in multiple cloudfront distributions Aug 25, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 26, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@jogold
Copy link
Contributor

jogold commented Aug 26, 2020

@eladb I think that this is the PR blocking everything...

From #9874, https://github.com/aws/aws-cdk/pull/9874/checks?check_run_id=1032914862:
image

@mergify
Copy link
Contributor

mergify bot commented Aug 26, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ecbc935
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 71c60f2 into master Aug 26, 2020
@mergify mergify bot deleted the nija-at/lambda-latestversion-cache branch August 26, 2020 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use the same Lambda version for 2 CloudFront distributions
5 participants