Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(custom-resources): support custom lambda role in provider framework #12131

Merged
merged 9 commits into from
Jun 7, 2021
Merged

feat(custom-resources): support custom lambda role in provider framework #12131

merged 9 commits into from
Jun 7, 2021

Conversation

Ruben-E
Copy link
Contributor

@Ruben-E Ruben-E commented Dec 17, 2020

Added support to pass a custom role to the provider which the lambda will use. Can be used a.o. to pass a permission boundary.

closes #12126

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@Ruben-E
feat(custom-resources): supported custom role for provider lambda
192c256 
Added support to pass a custom role to the provider which the lambda will use. Can be used a.o. to pass a permission boundary.

closes aws#12126
@gitpod-io
Copy link

gitpod-io bot commented Dec 17, 2020 •
edited
Loading

@github-actions github-actions bot added the @aws-cdk/custom-resources Related to AWS CDK Custom Resources label Dec 17, 2020
@aka-toxa aka-toxa mentioned this pull request Dec 18, 2020
Closed
2 tasks
rix0rrr
rix0rrr previously approved these changes Jan 6, 2021
View reviewed changes
@rix0rrr
Copy link
Contributor

rix0rrr commented Jan 6, 2021

You will need to resolve conflicts.

@mergify
Copy link
Contributor

mergify bot commented Jan 6, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@rix0rrr rix0rrr added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Mar 8, 2021
@github-actions
Copy link

github-actions bot commented Mar 9, 2021

This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Mar 9, 2021
@Ruben-E
Copy link
Contributor Author

Ruben-E commented Mar 10, 2021

Ah, I completely missed that this was still open. Will fix the conflicts.

@github-actions github-actions bot removed closing-soon This issue will automatically close in 4 days unless further comments are made. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Mar 11, 2021
@Ruben-E
Merge remote-tracking branch 'upstream/master' into provider-lambda-r…
6e864d9 
…ole-support

# Conflicts:
#	packages/@aws-cdk/custom-resources/lib/provider-framework/provider.ts
#	packages/@aws-cdk/custom-resources/test/provider-framework/provider.test.ts
@mergify mergify bot dismissed rix0rrr’s stale review March 23, 2021 08:14

Pull request has been modified.

@gitpod-io
Copy link

gitpod-io bot commented Jun 4, 2021

rix0rrr
rix0rrr previously approved these changes Jun 4, 2021
View reviewed changes
@mergify mergify bot dismissed rix0rrr’s stale review June 4, 2021 15:17

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 538f6be
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit bc01207 into aws:master Jun 7, 2021
@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@Ruben-E @hollanddd
feat(custom-resources): support custom lambda role in provider framew…
5afd312 
…ork (aws#12131)

Added support to pass a custom role to the provider which the lambda will use. Can be used a.o. to pass a permission boundary.

closes aws#12126


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(custom-resources): support custom lambda role in provider framework
3 participants
@Ruben-E @rix0rrr @aws-cdk-automation