Code cleanup

Author: Rakshil Modi

awscli/customizations/s3/subcommands.py

@@ -1346,7 +1346,6 @@ def run(self):
         }
         result_queue = queue.Queue()
         operation_name = cmd_translation[paths_type]
-        LOGGER.debug("OPERATION TYPE %s",operation_name)
 
         fgen_kwargs = {
             'client': self._source_client,

tests/functional/s3/test_cp_command.py

@@ -296,10 +296,10 @@ def test_operations_used_in_recursive_download(self):
         )
         self.assertEqual(self.operations_called[0][0].name, 'ListObjectsV2')
 
-    def test_no_overwrite_flag_when_object_not_exists_on_target(self):
-        """Test when object with different key is successsfully uploaded using no-overwrite"""
+    def test_for_no_overwrite_flag_when_object_not_exists_on_target(self):
+        """Testing when object with different key is successsfully uploaded using no-overwrite"""
         full_path = self.files.create_file('foo.txt', 'mycontent')
-        cmdline = '%s %s s3://bucket/key.txt --no-overwrite' % ( self.prefix,full_path)
+        cmdline = '%s %s s3://bucket --no-overwrite' % ( self.prefix,full_path)
         self.parsed_responses = [
             {'ETag': '"c8afdb36c52cf4727836669019e69222"'}
         ]
@@ -312,10 +312,10 @@ def test_no_overwrite_flag_when_object_not_exists_on_target(self):
         # Verify the IfNoneMatch condition was set in the request
         self.assertEqual(self.operations_called[0][1]['IfNoneMatch'], '*')
 
-    def test_no_overwrite_flag_when_object_exists_on_target(self):
-        """Test warning message when object already exists using no-overwrite"""
+    def test_for_no_overwrite_flag_when_object_exists_on_target(self):
+        """Testing  when object already exists using no-overwrite"""
         full_path = self.files.create_file('foo.txt', 'mycontent')
-        cmdline = '%s %s s3://bucket/key.txt --no-overwrite' % ( self.prefix,full_path)
+        cmdline = '%s %s s3://bucket --no-overwrite' % ( self.prefix,full_path)
         # Set up the response to simulate a PreconditionFailed error
         self.http_response.status_code = 412
         self.parsed_responses = [
@@ -332,11 +332,11 @@ def test_no_overwrite_flag_when_object_exists_on_target(self):
         self.assertEqual(self.operations_called[0][0].name, 'PutObject')
         self.assertEqual(self.operations_called[0][1]['IfNoneMatch'], '*')
 
-    def test_no_overwrite_flag_multipart_upload_when_object_not_exists_on_target(self):
-        """Test multipart upload with no-overwrite flag when object doesn't exist"""
+    def test_for_no_overwrite_flag_multipart_upload_when_object_not_exists_on_target(self):
+        """Testing multipart upload with no-overwrite flag when object doesn't exist"""
         # Create a large file that will trigger multipart upload
         full_path = self.files.create_file('foo.txt', 'a' * 10 * (1024**2))
-        cmdline = '%s %s s3://bucket/key.txt --no-overwrite' % (self.prefix, full_path)
+        cmdline = '%s %s s3://bucket --no-overwrite' % (self.prefix, full_path)
 
         # Set up responses for multipart upload
         self.parsed_responses = [
@@ -358,7 +358,6 @@ def test_no_overwrite_flag_multipart_upload_when_object_not_exists_on_target(sel
         # Verify the IfNoneMatch condition was set in the CompleteMultipartUpload request
         self.assertEqual(self.operations_called[3][1]['IfNoneMatch'], '*')
 
-
     def test_dryrun_download(self):
         self.parsed_responses = [self.head_object_response()]
         target = self.files.full_path('file.txt')