Print better error when using pagination params and no paginate #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
force-pushed
the
really-no-paginate
branch
from
e9bf4fe
to
176088b
Compare
| if not parsed_globals.paginate and \ | ||
| 'PaginationConfig' in call_parameters: | ||
| raise PaginationError(message="--no-paginate provided along with " | ||
| "pagination arguments.") |
There was a problem hiding this comment.
I would to prefer to put this logic here for the following reasons:
- It is weird to have this pagination logic right in the middle of the clidriver
- You can have context as to what pagination parameters when they used
--no-paginateand thus have a better error message.
|
Had a comment on how to improve the error message and placement of the logic. |
JordonPhillips
force-pushed
the
really-no-paginate
branch
2 times, most recently
from
2ba5ce6
to
d9f311d
Compare
JordonPhillips
force-pushed
the
really-no-paginate
branch
2 times, most recently
from
da734fc
to
4b56085
Compare
| converted_params = ', '.join( | ||
| ["--" + p.replace('_', '-') for p in params_used]) | ||
| raise PaginationError( | ||
| message="--no-paginate provided along with pagination " |
There was a problem hiding this comment.
We can make the message a tad more explicit such as Cannot specify --no-paginate along with pagination arguments: ...?
|
Looks good. Just had a couple of small comments. Otherwise 🚢 |
|
Looks good to me aside from Kyle's feedback. Putting in incorporating-feedback to track incorporating Kyle's feedback. |
jamesls
added
incorporating-feedback
and removed
pr:needs-review
This makes the error message when pagination paramters are passed in along with --no-paginate more helpful.
JordonPhillips
force-pushed
the
really-no-paginate
branch
from
4b56085
to
12aa790
Compare
|
Updated error message and functional test. |
|
Thanks! 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the error message when pagination paramters are passed in
along with --no-paginate more helpful.
cc @kyleknap @jamesls