Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed yaml parsing error for !GetAtt #2332

Merged
merged 1 commit into from
Jan 6, 2017
Merged

Fixed yaml parsing error for !GetAtt #2332

merged 1 commit into from
Jan 6, 2017

Conversation

dtimberlake
Copy link
Contributor

When parsing !GetAtt, attributes should not be split on periods.

Example:

Original:

!GetAtt MyStack.Outputs.Arn

Parses to:

{ "Fn::GetAtt": [ "MyStack", "Outputs", "Arn" ] }

Should be:

{ "Fn::GetAtt": [ "MyStack", "Outputs.Arn" ] }

@jamesls
Copy link
Member

jamesls commented Dec 22, 2016

Good catch, thanks for the pull request.

@jamesls jamesls added the pr:needs-review This PR needs a review from a Member. label Dec 22, 2016
@jamesls jamesls merged commit 9b69a93 into aws:develop Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. cloudformation package-deploy pr:needs-review This PR needs a review from a Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants