Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws s3 commands should not be checking regions #681

Closed
jamesls opened this issue Mar 3, 2014 · 0 comments · Fixed by #682
Closed

aws s3 commands should not be checking regions #681

jamesls opened this issue Mar 3, 2014 · 0 comments · Fixed by #682

Comments

@jamesls
Copy link
Member

jamesls commented Mar 3, 2014

There's currently code in the high level s3 commands that validate that a region is specified (either through a CLI param, env vars, or config file). However, botocore does not require a region as s3 is marked as a "global" service at the botocore layer. This makes the region validation inconsistent between s3 and s3api, as s3api does not require a region.

We should be able to safely remove check_region in this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant