Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is colorama pinned to 0.4.5? #8571

Closed
Lawouach opened this issue Mar 11, 2024 · 2 comments
Closed

Why is colorama pinned to 0.4.5? #8571

Lawouach opened this issue Mar 11, 2024 · 2 comments
Assignees
Labels
dependencies This issue is a problem in a dependency. investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 This is a standard priority issue source-distribution cli v2 source distritbution related issues

Comments

@Lawouach
Copy link

Describe the issue

Currently, the colorama dependency is pinned to colorama>=0.2.5,<0.4.5. Is there a particular reason as this means we cannot upgrade some other packages that expect 0.4.6

Additional Information/Context

No response

CLI version used

latest

Environment details (OS name and version, etc.)

linux

@Lawouach Lawouach added needs-triage This issue or PR still needs to be triaged. source-distribution cli v2 source distritbution related issues labels Mar 11, 2024
@RyanFitzSimmonsAK RyanFitzSimmonsAK added the dependencies This issue is a problem in a dependency. label Apr 2, 2024
@RyanFitzSimmonsAK RyanFitzSimmonsAK self-assigned this Apr 2, 2024
@RyanFitzSimmonsAK RyanFitzSimmonsAK added investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Apr 2, 2024
@RyanFitzSimmonsAK
Copy link
Contributor

Hi @Lawouach, thanks for your patience. I assume you're referring specifically to the AWS CLI v1 pin, since v2 has a higher pin already. If you're able to upgrade to CLI v2, that should allow you to use the higher colorama version. Dependencies for v1 and v2 are tracked separately, we do have an open PR for this dependency. I've asked the team to take a look at the colorama pin the next time they review dependencies. In the meantime, as we have a general tracking issue for dependency pins, I'm going to close this as a duplicate.

@RyanFitzSimmonsAK RyanFitzSimmonsAK closed this as not planned Won't fix, can't repro, duplicate, stale Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies This issue is a problem in a dependency. investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 This is a standard priority issue source-distribution cli v2 source distritbution related issues
Projects
None yet
Development

No branches or pull requests

2 participants