Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong formatting in the deprecated python warning #524

Open
ShubhamChaturvedi7 opened this issue Jan 20, 2023 · 3 comments
Open

Wrong formatting in the deprecated python warning #524

ShubhamChaturvedi7 opened this issue Jan 20, 2023 · 3 comments

Comments

@ShubhamChaturvedi7
Copy link
Contributor

Security issue notifications

If you discover a potential security issue in the Amazon DynamoDB Encryption Client we ask that you notify AWS Security via our vulnerability reporting page. Please do not create a public GitHub issue.

Problem:

).format(py_version[0], py_version[1], minimum_version[0], minimum_version[1], params["date"])

The minimum_version and date seem to have been swapped in the deprecated python warning.

Solution:

Putting the params["date"] before the minimum_version[0] should fix the issue.

Out of scope:

Is there anything the solution will intentionally NOT address?

@mattsb42-aws
Copy link
Member

Since you don't support <3.6 anymore, you could also replace this with fstrings. ;)

@khubaibalam2000
Copy link
Contributor

Can I work on this issue?

@bawejahritik
Copy link

Is this issue still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants