Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment of function parameter has no effect outside the function. #95

Closed
fedex03 opened this issue Aug 28, 2017 · 1 comment
Closed
Labels

Comments

@fedex03
Copy link

fedex03 commented Aug 28, 2017

Hi there,

I'm using the aws-iot-device-sdk-embedded-C into an embedded project and when I run a static code analysis with "CppCheck" I find this error:

Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?

pJsonHandler = (void *) jsonTokenStruct;

into the function isJsonValidAndParse.

service/aws_mqtt/src/aws_iot_shadow_json.c @ line 364

This bug is already found and fixed or not?

Thanks for the help!

@hedeshianaws
Copy link
Contributor

Thank you for reporting this bug. Yes, I believe that line should be

*pJsonHandler = (void *) jsonTokenStruct;

We've made a note of it internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants