Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make StatusCode and Body available in IHttpResult/HttpResult #1468

Closed
1 of 2 tasks
kabaluk opened this issue Mar 27, 2023 · 2 comments
Closed
1 of 2 tasks

Make StatusCode and Body available in IHttpResult/HttpResult #1468

kabaluk opened this issue Mar 27, 2023 · 2 comments
Labels
feature-request A feature should be added or improved. module/lambda-client-lib p2 This is a standard priority issue queued

Comments

@kabaluk
Copy link
Contributor

kabaluk commented Mar 27, 2023

Describe the feature

Make StatusCode and Body available in IHttpResult/HttpResult,
this would make unit testing lambdas returning IHttpResults a lot simpler.

Use Case

A lot of Api's return either 200 OK or 400 BadRequest.
There is no easy way to unit test if the result of a Annotation Lambda is returning the correct httpStatus and or body

Proposed Solution

Make Status code and body available on IHttpResult and/or HttpResult.
The fields are already mandatory in HttpResult, no Reason for them to not be public (or at least public get)

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS .NET SDK and/or Package version used

Amazon.Lambda.Annotations 0.13.0.0

Targeted .NET Platform

.NET6

Operating System and version

ALL SUPPORTED

@kabaluk kabaluk added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 27, 2023
@ashishdhingra
Copy link
Contributor

@kabaluk Good afternoon. Thanks for submitting feature request. The commit e44e48d added support for 5XX status codes to Annotations framework. Are you referring to add other status codes? Feel free to contribute PR which could be reviewed by the team.

Thanks,
Ashish

@ashishdhingra ashishdhingra added needs-review p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Mar 27, 2023
@kabaluk kabaluk closed this as completed May 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. module/lambda-client-lib p2 This is a standard priority issue queued
Projects
None yet
Development

No branches or pull requests

2 participants