Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contents of self-created Lambda Runtime image differes from expected #987

Closed
TrongTheAlpaca opened this issue Nov 19, 2021 · 4 comments
Closed
Labels
guidance Question that needs advice or information. module/custom-runtime response-requested Waiting on additional info and feedback. Will move to close soon in 7 days.

Comments

@TrongTheAlpaca
Copy link

Preface

At the time of writing, the official .NET 6 Lambda image has not been pushed to the following image repositories:

A relevant issue is brought up here:

Description

A temporary fix is to create the needed runtime image yourself, explained in #889 (comment).

Unsure if it is intended, but the resulting .NET 6 image created using the mentioned instructions differs in structure from the official images. To properly highlight this difference, I will ignore comparison with .NET 6 image and only use .NET 5 as a point of reference, as the problem is reproducable with that version as well.

See images below (ignore highlighted words):

imageimage
Left tree: Content tree to the is from the image public.ecr.aws/lambda/dotnet:5.0 from https://gallery.ecr.aws/lambda/dotnet
Right tree: Content tree of the created image when following the instructions from #889 (comment) to create a .NET 5 image.

Note that Bootstrap.sh is not found in the same location. For the self-created .NET 5 lambda image, the file is instead in var/runtime/Bootstrap.sh, as seen below:
image

As mentioned above, creating a .NET 6 equivalent image will have a similar structure.
Is this difference intended? I can imagine that this does have an implication on the usage of the images.

@TrongTheAlpaca TrongTheAlpaca added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 19, 2021
@TrongTheAlpaca
Copy link
Author

Am I correct that this difference is due to this specific commit: 9668ee8?
It seems intentional? Does this change have implications on how Lambda functions interact with the image compared to older versions of the image?

@normj
Copy link
Member

normj commented Dec 8, 2021

The change was intentional to match other Lambda runtimes. It won't have any impact to the experience because the /lambda-entrypoint.sh is used as the container entrypoint. The lambda-entrypoint.sh script has been updated but the location hasn't changed for that file.

@aaoswal aaoswal added response-requested Waiting on additional info and feedback. Will move to close soon in 7 days. guidance Question that needs advice or information. and removed needs-triage This issue or PR still needs to be triaged. bug This issue is a bug. labels Dec 8, 2021
@TrongTheAlpaca
Copy link
Author

Ah I see, thanks! The answer is sufficient, so I will be closing this issue now.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guidance Question that needs advice or information. module/custom-runtime response-requested Waiting on additional info and feedback. Will move to close soon in 7 days.
Projects
None yet
Development

No branches or pull requests

4 participants