Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] graph plugin does not respect per-diagram FilterPlan config #649

Open
anentropic opened this issue Nov 14, 2023 · 3 comments
Open
Labels
backlog bug Something isn't working

Comments

@anentropic
Copy link

Describe the bug

using this code (Python)

graph = CdkGraph(
    app,
    plugins=[
        cast(
            ICdkGraphPlugin,
            CdkGraphDiagramPlugin(
                diagrams=[
                    {
                        "title": "unfiltered",
                        "name": "unfiltered",
                        "filter_plan": {
                            "preset": FilterPreset.NONE,
                        },
                    },
                    {
                        "title": "non-extraneous",
                        "name": "non-extraneous",
                        "filter_plan": {
                            "preset": FilterPreset.NON_EXTRANEOUS,
                        },
                    },
                    {
                        "title": "compact",
                        "name": "compact",
                        "filter_plan": {
                            "preset": FilterPreset.COMPACT,
                        },
                    },
                ]
            ),
        )
    ],
)

...when I run this I get three files all output using the FilterPreset.COMPACT style

Expected Behavior

each diagram output should respect its own FilterPlan config

Current Behavior

all the files come out in FilterPreset.COMPACT style (maybe last-defined wins?)

Reproduction Steps

see above

Possible Solution

No response

Additional Information/Context

No response

PDK version used

0.22.41

What languages are you seeing this issue on?

Python

Environment details (OS name and version, etc.)

macOS 14.1

@anentropic anentropic added the bug Something isn't working label Nov 14, 2023
@agdimech
Copy link
Contributor

@JeremyJonas - can you please look into this?

Copy link

This issue is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon. If you wish to exclude this issue from being marked as stale, add the "backlog" label.

@github-actions github-actions bot added the stale label Jan 29, 2024
Copy link

github-actions bot commented Feb 5, 2024

Closing this issue as it hasn't seen activity for a while. Please add a comment @mentioning a maintainer to reopen. If you wish to exclude this issue from being marked as stale, add the "backlog" label.

@github-actions github-actions bot closed this as completed Feb 5, 2024
@cogwirrel cogwirrel reopened this Sep 17, 2024
@github-actions github-actions bot removed the stale label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants