fix(type-safe-api): missing runtime modules in Lambda deployment #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the issue where generated runtime modules were not packaged in the Lambda deployment, causing ImportModuleError when executing Python handlers. The fix modifies the packaging task in GeneratedPythonHandlersBaseProject to strip the '-e' flag from exported requirements.txt. This ensures runtime modules are installed as regular packages instead of editable installations. Changes: - Update 'poetry export' command to pipe output through 'sed' and remove '-e' prefix. - Update corresponding snapshot tests for new package task command. Fixes aws#791
agdimech
approved these changes
Jul 25, 2024
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2750cc2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where generated runtime modules were not packaged in the Lambda deployment, causing ImportModuleError when executing Python handlers.
The fix modifies the packaging task in GeneratedPythonHandlersBaseProject to strip the '-e' flag from exported requirements.txt. This ensures runtime modules are installed as regular packages instead of editable installations.
Changes:
Fixes #791