-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deadline): adding deadline version check for workers #100
Conversation
While configuring deadline workers if the installed deadline client version is less than the minimum supported deadline version then we now fail during deployment. Also updating the deadline readme. Verified by installing a higher and lower versions for both windows and linux.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor suggestions, but otherwise this will be great and could save a lot of potential headaches. Great stuff!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. One last suggested change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just about ready. Just a minor question about the TSDoc warning added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
While configuring deadline workers if the installed deadline
client version is less than the minimum supported deadline version
then we now fail during deployment.
Also updating the deadline readme.
Verified by installing a higher and lower versions for both
windows and linux.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license