-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deadline): add Deadline Secrets Management integration in the Render Queue #528
feat(deadline): add Deadline Secrets Management integration in the Render Queue #528
Conversation
49beb5b
to
0271773
Compare
0271773
to
af3b471
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just a few minor things that are hopefully quick fixes.
packages/aws-rfdk/lib/deadline/scripts/bash/installDeadlineRepository.sh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great job here. Just two small suggestions around the validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion remaining.
e43025b
to
8bd66a4
Compare
Depends on:
Notes
Adds Deadline Secrets Management configuration to the
RenderQueue
construct.Testing
ListAllMachines
,ListAllSecrets
,PutSecret
, andGetSecret
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license