Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bulk update of all dependencies #104

Merged
merged 4 commits into from
Aug 28, 2020

Conversation

ddneilson
Copy link
Contributor

There's some tangling between our dependencies that make them tricky for Dependabot to update on its own. This is a bulk update of all of our deps; mostly to address the security issue with dot-prop.

The more notable updates are:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@ddneilson ddneilson requested review from jusiskin and grbartel August 28, 2020 18:16
@ddneilson ddneilson added the contribution/core This is a PR that came from AWS. label Aug 28, 2020
grbartel
grbartel previously approved these changes Aug 28, 2020
Copy link
Contributor

@grbartel grbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@jusiskin jusiskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Just one small thing I'm not sure about in the python sample app.

Comment on lines 20 to 21
"aws-cdk.core==1.61.1",
"aws-rfdk==0.17.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this....

Version 0.17.0 of RFDK uses CDK 1.57.0, right?

Copy link
Contributor Author

@ddneilson ddneilson Aug 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches the Typescript version of the example. Hrm... that's a pickle. I guess we'll have to leave the examples on the last release, and bump them (including CDK version) on release.

integ will have to be different. It's intended to be used with the tip-of-mainline.

@ddneilson
Copy link
Contributor Author

Note: I had to remove building our example app from the build.sh script. There's a conflict in CDK dependency versions between release RFDK & development RFDK. We want the examples to match release RFDK so that customers can use them as-is.

@jusiskin jusiskin merged commit 09f236e into aws:mainline Aug 28, 2020
@ddneilson ddneilson deleted the bulk_update_deps branch March 17, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants