fix(integ): fix rate limit errors when deploying cloudwatch log group… #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in integration tests
jusiskin
requested changes
Sep 27, 2022
jusiskin
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem #807
This is a continuous fix following #822. The previous fix partially solved the problem, and integration test still got random failures from other lambdas where LogRetention is defined implicitly without retries (e.g. certificate function).
Solution
Add
LogRetentionRetryOptionsto all lambdas and extend log retention function timeout for all integration test stacks via Aspect. Similar to SSMInstancePolicyAspect, it is only for integration test and not being added to example stacks for now.Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license