Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Templates written through CDK through reading Resource Level Metadata #893

Closed
jfuss opened this issue Dec 27, 2018 · 6 comments
Closed
Assignees
Labels
stage/waiting-for-release Fix has been merged to develop and is waiting for a release

Comments

@jfuss
Copy link
Contributor

jfuss commented Dec 27, 2018

Describe your idea/feature/enhancement

Currently, AWS SAM CLI only supports templates that are written in CloudFormation (.json or .yaml files). This leaves out other frameworks like CDK that produce a template. SAM CLI should support these use-cases.

Proposal

A design will need to be written for this support. CDK is adding some support to enable the bridging [1] of the tools. The design should capture how we will support templates written through CDK but should keep in mind how we can expand to other frameworks as well (Serverless Framework for example).

[1] aws/aws-cdk#1433

Additional Details

Other related issues

@jfuss jfuss self-assigned this Dec 27, 2018
@jfuss jfuss added the stage/in-progress A fix is being worked on label Jan 8, 2019
@tj
Copy link

tj commented Jan 10, 2019

Personally I find it pretty elegant that anything that wants to work with SAM can just generate some .json or .yaml

@eladb
Copy link

eladb commented Jan 10, 2019

@tj 👋

@jfuss
Copy link
Contributor Author

jfuss commented Jan 16, 2019

The design and implementation for supporting Resource Level Metadata is done and merged. Only thing left is to release. Updating labels and the issue title to be more accurate (instead of closing and opening another one to track release).

@jfuss jfuss added stage/waiting-for-release Fix has been merged to develop and is waiting for a release and removed stage/in-progress A fix is being worked on labels Jan 16, 2019
@jfuss jfuss changed the title Design: Support Templates written through CDK Support Templates written through CDK through reading Resource Level Metadata Jan 16, 2019
@jfuss
Copy link
Contributor Author

jfuss commented Jan 16, 2019

This will also allow people using Amplify to run and test locally with SAM CLI: aws-amplify/amplify-cli#693

@dhruvsood dhruvsood added this to the Active milestone Jan 18, 2019
@dhruvsood dhruvsood modified the milestones: Active, Release: v0.11.0 Jan 25, 2019
@jfuss
Copy link
Contributor Author

jfuss commented Feb 5, 2019

Released in v0.11.0

Closing

@jfuss jfuss closed this as completed Feb 5, 2019
@eladb
Copy link

eladb commented Feb 6, 2019

Yey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage/waiting-for-release Fix has been merged to develop and is waiting for a release
Projects
None yet
Development

No branches or pull requests

4 participants