Skip to content

fix: usability fixes on deploy error with no s3 bucket #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sriram-mv merged 1 commit into from
Nov 20, 2019
Merged

fix: usability fixes on deploy error with no s3 bucket #1561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samcli/commands/deploy/deploy_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class DeployContext:

MSG_EXECUTE_SUCCESS = "\nSuccessfully created/updated stack - {stack_name} in {region}\n"

MSG_CONFIRM_CHANGESET = "Confirm deploying?"
MSG_CONFIRM_CHANGESET = "Deploy this changeset?"
MSG_CONFIRM_CHANGESET_HEADER = "\nPreviewing CloudFormation changeset before deployment"

def __init__(
Expand Down
2 changes: 1 addition & 1 deletion samcli/commands/package/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,6 @@ class BucketNotSpecifiedError(UserException):
def __init__(self, **kwargs):
self.kwargs = kwargs

message_fmt = "\nS3 Bucket not specified, use --s3-bucket to specify a bucket name"
message_fmt = "\nS3 Bucket not specified, use --s3-bucket to specify a bucket name or run sam deploy --guided"

super(BucketNotSpecifiedError, self).__init__(message=message_fmt.format(**self.kwargs))
3 changes: 2 additions & 1 deletion tests/unit/lib/package/test_s3_uploader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,10 @@ def test_s3_upload_no_bucket(self):
)
s3_uploader.artifact_metadata = {"a": "b"}
remote_path = Path.joinpath(Path(os.getcwd()), Path("tmp"))
with self.assertRaises(BucketNotSpecifiedError):
with self.assertRaises(BucketNotSpecifiedError) as ex:
with tempfile.NamedTemporaryFile(mode="w", delete=False) as f:
s3_uploader.upload(f.name, remote_path)
self.assertEqual(BucketNotSpecifiedError().message, str(ex))

def test_s3_upload_with_dedup(self):
s3_uploader = S3Uploader(
Expand Down