Sam delete integration testing #3076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

moelasmar merged 53 commits into aws:feat/sam_delete from hnnasit:sam-delete-testing

Jul 20, 2021

tests/integration/delete/__init__.py

Empty file.

tests/integration/delete/delete_integ_base.py

-Original file line number
+Diff line change
@@ -0,0 +1,41 @@
+    import os
+    from unittest import TestCase
+    class DeleteIntegBase(TestCase):
+        @classmethod
+        def setUpClass(cls):
+            pass
+        def setUp(self):
+            super().setUp()
+        def tearDown(self):
+            super().tearDown()
+        def base_command(self):
+            command = "sam"
+            if os.getenv("SAM_CLI_DEV"):
+                command = "samdev"
+            return command
+        def get_delete_command_list(
+            self, stack_name=None, region=None, config_file=None, config_env=None, profile=None, no_prompts=None
+        ):
+            command_list = [self.base_command(), "delete"]
+            if stack_name:
+                command_list += ["--stack-name", str(stack_name)]
+            if region:
+                command_list += ["--region", str(region)]
+            if config_file:
+                command_list += ["--config-file", str(config_file)]
+            if config_env:
+                command_list += ["--config-env", str(config_env)]
+            if profile:
+                command_list += ["--profile", str(profile)]
+            if no_prompts:
+                command_list += ["--no-prompts"]
+            return command_list

tests/integration/delete/test_delete_command.py

-Original file line number
+Diff line change
@@ -0,0 +1,334 @@
+    import os
+    import shutil
+    import tempfile
+    import time
+    import uuid
+    from pathlib import Path
+    from unittest import skipIf
+    import logging
+    import boto3
+    import docker
+    from botocore.config import Config
+    from parameterized import parameterized
+    from botocore.exceptions import ClientError
+    from samcli.lib.bootstrap.bootstrap import SAM_CLI_STACK_NAME
+    from samcli.lib.config.samconfig import DEFAULT_CONFIG_FILE_NAME
+    from tests.integration.deploy.deploy_integ_base import DeployIntegBase
+    from tests.integration.delete.delete_integ_base import DeleteIntegBase
+    from tests.integration.package.package_integ_base import PackageIntegBase
+    from tests.testing_utils import RUNNING_ON_CI, RUNNING_TEST_FOR_MASTER_ON_CI, RUN_BY_CANARY
+    from tests.testing_utils import run_command, run_command_with_input
+    # Delete tests require credentials and CI/CD will only add credentials to the env if the PR is from the same repo.
+    # This is to restrict package tests to run outside of CI/CD, when the branch is not master or tests are not run by Canary
+    SKIP_DELETE_TESTS = RUNNING_ON_CI and RUNNING_TEST_FOR_MASTER_ON_CI and not RUN_BY_CANARY
+    CFN_SLEEP = 3
+    TIMEOUT = 300
+    CFN_PYTHON_VERSION_SUFFIX = os.environ.get("PYTHON_VERSION", "0.0.0").replace(".", "-")
+    LOG = logging.getLogger(__name__)
+    @skipIf(SKIP_DELETE_TESTS, "Skip delete tests in CI/CD only")
+    class TestDelete(PackageIntegBase, DeployIntegBase, DeleteIntegBase):
+        @classmethod
+        def setUpClass(cls):
+            cls.docker_client = docker.from_env()
+            cls.local_images = [
+                ("alpine", "latest"),
+            ]
+            # setup some images locally by pulling them.
+            for repo, tag in cls.local_images:
+                cls.docker_client.api.pull(repository=repo, tag=tag)
+            PackageIntegBase.setUpClass()
+            DeployIntegBase.setUpClass()
+            DeleteIntegBase.setUpClass()
+        def setUp(self):
+            self.cf_client = boto3.client("cloudformation")
+            self.sns_arn = os.environ.get("AWS_SNS")
+            time.sleep(CFN_SLEEP)
+            super().setUp()
+        def test_delete_command_no_stack_deployed(self):
+            stack_name = self._method_to_stack_name(self.id())
+            delete_command_list = self.get_delete_command_list(stack_name=stack_name, no_prompts=True)
+            delete_process_execute = run_command(delete_command_list)
+            self.assertEqual(delete_process_execute.process.returncode, 0)
+            self.assertIn(
+                f"Error: The input stack {stack_name} does not exist on Cloudformation", str(delete_process_execute.stdout)
+            )
+        @parameterized.expand(
+            [
+                "aws-serverless-function.yaml",
+                "aws-serverless-statemachine.yaml",
+                "aws-appsync-graphqlschema.yaml",
+                "aws-appsync-resolver.yaml",
+                "aws-appsync-functionconfiguration.yaml",
+                "aws-apigateway-restapi.yaml",
+                "aws-elasticbeanstalk-applicationversion.yaml",
+                "aws-cloudformation-moduleversion.yaml",
+                "aws-cloudformation-resourceversion.yaml",
+                "aws-cloudformation-stack.yaml",
+                "aws-serverless-application.yaml",
+                "aws-lambda-layerversion.yaml",
+                "aws-serverless-layerversion.yaml",
+                "aws-glue-job.yaml",
+                "aws-stepfunctions-statemachine.yaml",
+            ]
+        )
+        def test_delete_with_s3_prefix_present_zip(self, template_file):
+            template_path = self.test_data_path.joinpath(template_file)
+            stack_name = self._method_to_stack_name(self.id())
+            config_file_name = stack_name + ".toml"
+            deploy_command_list = self.get_deploy_command_list(
+                template_file=template_path, guided=True, config_file=config_file_name
+            )
+            deploy_process_execute = run_command_with_input(
+                deploy_command_list, "{}\n\n\n\n\n\n\n\n\n".format(stack_name).encode()
+            )
+            config_file_path = self.test_data_path.joinpath(config_file_name)
+            delete_command_list = self.get_delete_command_list(
+                stack_name=stack_name, config_file=config_file_path, no_prompts=True
+            )
+            delete_process_execute = run_command(delete_command_list)
+            self.assertEqual(delete_process_execute.process.returncode, 0)
+            try:
+                resp = self.cf_client.describe_stacks(StackName=stack_name)
+            except ClientError as ex:
+                self.assertIn(f"Stack with id {stack_name} does not exist", str(ex))
+            # Remove the local config file created
+            if os.path.isfile(config_file_path):
+                os.remove(config_file_path)
+        @parameterized.expand(
+            [
+                "aws-serverless-function-image.yaml",
+            ]
+        )
+        def test_delete_with_s3_prefix_present_image(self, template_file):
+            template_path = self.test_data_path.joinpath(template_file)
+            stack_name = self._method_to_stack_name(self.id())
+            config_file_name = stack_name + ".toml"
+            deploy_command_list = self.get_deploy_command_list(
+                template_file=template_path, guided=True, config_file=config_file_name
+            )
+            deploy_process_execute = run_command_with_input(
+                deploy_command_list, f"{stack_name}\n\n{self.ecr_repo_name}\n\n\ny\n\n\n\n\n\n".encode()
+            )
+            config_file_path = self.test_data_path.joinpath(config_file_name)
+            delete_command_list = self.get_delete_command_list(
+                stack_name=stack_name, config_file=config_file_path, no_prompts=True
+            )
+            delete_process_execute = run_command(delete_command_list)
+            self.assertEqual(delete_process_execute.process.returncode, 0)
+            try:
+                resp = self.cf_client.describe_stacks(StackName=stack_name)
+            except ClientError as ex:
+                self.assertIn(f"Stack with id {stack_name} does not exist", str(ex))
+            # Remove the local config file created
+            if os.path.isfile(config_file_path):
+                os.remove(config_file_path)
+        @parameterized.expand(
+            [
+                "aws-serverless-function.yaml",
+            ]
+        )
+        def test_delete_guided_prompts(self, template_file):
+            template_path = self.test_data_path.joinpath(template_file)
+            stack_name = self._method_to_stack_name(self.id())
+            config_file_name = stack_name + ".toml"
+            deploy_command_list = self.get_deploy_command_list(
+                template_file=template_path, guided=True, config_file=config_file_name
+            )
+            deploy_process_execute = run_command_with_input(
+                deploy_command_list, "{}\n\n\n\n\n\n\n\n\n".format(stack_name).encode()
+            )
+            config_file_path = self.test_data_path.joinpath(config_file_name)
+            delete_command_list = self.get_delete_command_list(stack_name=stack_name, config_file=config_file_path)
+            LOG.info(delete_command_list)
+            delete_process_execute = run_command_with_input(delete_command_list, "y\nn\ny\n".encode())
+            self.assertEqual(delete_process_execute.process.returncode, 0)
+            try:
+                resp = self.cf_client.describe_stacks(StackName=stack_name)
+            except ClientError as ex:
+                self.assertIn(f"Stack with id {stack_name} does not exist", str(ex))
+            # Remove the local config file created
+            if os.path.isfile(config_file_path):
+                os.remove(config_file_path)
+        @parameterized.expand(
+            [
+                "aws-serverless-function.yaml",
+            ]
+        )
+        def test_delete_no_config_file_zip(self, template_file):
+            template_path = self.test_data_path.joinpath(template_file)
+            stack_name = self._method_to_stack_name(self.id())
+            deploy_command_list = self.get_deploy_command_list(template_file=template_path, guided=True)
+            deploy_process_execute = run_command_with_input(
+                deploy_command_list, "{}\n\n\n\n\nn\n\n\n".format(stack_name).encode()
+            )
+            delete_command_list = self.get_delete_command_list(stack_name=stack_name, region="us-east-1", no_prompts=True)
+            delete_process_execute = run_command(delete_command_list)
+            self.assertEqual(delete_process_execute.process.returncode, 0)
+            try:
+                resp = self.cf_client.describe_stacks(StackName=stack_name)
+            except ClientError as ex:
+                self.assertIn(f"Stack with id {stack_name} does not exist", str(ex))
+        @parameterized.expand(
+            [
+                "aws-serverless-function.yaml",
+            ]
+        )
+        def test_delete_no_s3_prefix_zip(self, template_file):
+            template_path = self.test_data_path.joinpath(template_file)
+            stack_name = self._method_to_stack_name(self.id())
+            deploy_command_list = self.get_deploy_command_list(
+                template_file=template_path,
+                stack_name=stack_name,
+                capabilities="CAPABILITY_IAM",
+                s3_bucket=self.bucket_name,
+                force_upload=True,
+                notification_arns=self.sns_arn,
+                parameter_overrides="Parameter=Clarity",
+                kms_key_id=self.kms_key,
+                no_execute_changeset=False,
+                tags="integ=true clarity=yes foo_bar=baz",
+                confirm_changeset=False,
+                region="us-east-1",
+            )
+            deploy_process_execute = run_command(deploy_command_list)
+            delete_command_list = self.get_delete_command_list(stack_name=stack_name, region="us-east-1", no_prompts=True)
+            delete_process_execute = run_command(delete_command_list)
+            self.assertEqual(delete_process_execute.process.returncode, 0)
+            try:
+                resp = self.cf_client.describe_stacks(StackName=stack_name)
+            except ClientError as ex:
+                self.assertIn(f"Stack with id {stack_name} does not exist", str(ex))
+        @parameterized.expand(
+            [
+                "aws-serverless-function-image.yaml",
+            ]
+        )
+        def test_delete_no_s3_prefix_image(self, template_file):
+            template_path = self.test_data_path.joinpath(template_file)
+            stack_name = self._method_to_stack_name(self.id())
+            # Try to deploy to another region.
+            deploy_command_list = self.get_deploy_command_list(
+                template_file=template_path,
+                stack_name=stack_name,
+                capabilities="CAPABILITY_IAM",
+                image_repository=self.ecr_repo_name,
+                s3_bucket=self.bucket_name,
+                force_upload=True,
+                notification_arns=self.sns_arn,
+                parameter_overrides="Parameter=Clarity",
+                kms_key_id=self.kms_key,
+                no_execute_changeset=False,
+                tags="integ=true clarity=yes foo_bar=baz",
+                confirm_changeset=False,
+                region="us-east-1",
+            )
+            deploy_process_execute = run_command(deploy_command_list)
+            delete_command_list = self.get_delete_command_list(stack_name=stack_name, region="us-east-1", no_prompts=True)
+            delete_process_execute = run_command(delete_command_list)
+            self.assertEqual(delete_process_execute.process.returncode, 0)
+            try:
+                resp = self.cf_client.describe_stacks(StackName=stack_name)
+            except ClientError as ex:
+                self.assertIn(f"Stack with id {stack_name} does not exist", str(ex))
+        @parameterized.expand(
+            [os.path.join("deep-nested", "template.yaml"), os.path.join("deep-nested-image", "template.yaml")]
+        )
+        def test_delete_nested_stacks(self, template_file):
+            template_path = self.test_data_path.joinpath(template_file)
+            stack_name = self._method_to_stack_name(self.id())
+            # Package and Deploy in one go without confirming change set.
+            deploy_command_list = self.get_deploy_command_list(
+                template_file=template_path,
+                stack_name=stack_name,
+                # Note(xinhol): --capabilities does not allow passing multiple, we need to fix it
+                # here we use samconfig-deep-nested.toml as a workaround
+                config_file=self.test_data_path.joinpath("samconfig-deep-nested.toml"),
+                s3_prefix="integ_deploy",
+                s3_bucket=self.s3_bucket.name,
+                force_upload=True,
+                notification_arns=self.sns_arn,
+                kms_key_id=self.kms_key,
+                no_execute_changeset=False,
+                tags="integ=true clarity=yes foo_bar=baz",
+                confirm_changeset=False,
+                image_repository=self.ecr_repo_name,
+            )
+            deploy_process_execute = run_command(deploy_command_list)
+            delete_command_list = self.get_delete_command_list(stack_name=stack_name, region="us-east-1", no_prompts=True)
+            delete_process_execute = run_command(delete_command_list)
+            self.assertEqual(delete_process_execute.process.returncode, 0)
+            try:
+                resp = self.cf_client.describe_stacks(StackName=stack_name)
+            except ClientError as ex:
+                self.assertIn(f"Stack with id {stack_name} does not exist", str(ex))
+        def _method_to_stack_name(self, method_name):
+            """Method expects method name which can be a full path. Eg: test.integration.test_deploy_command.method_name"""
+            method_name = method_name.split(".")[-1]
+            return f"{method_name.replace('_', '-')}-{CFN_PYTHON_VERSION_SUFFIX}"

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sam delete integration testing #3076

Uh oh!

Diff view

Diff view

There are no files selected for viewing