Skip to content

fix: Repair failing integration test #5698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucashuy merged 2 commits into from
Aug 3, 2023
Merged

fix: Repair failing integration test #5698

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95b37d3
Fix failing integration test
Aug 3, 2023
3ea305b
Be more specific with error message
Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/integration/deploy/test_deploy_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,7 +826,11 @@ def test_deploy_with_invalid_config(self, template_file, config_file):

deploy_process_execute = self.run_command(deploy_command_list)
self.assertEqual(deploy_process_execute.process.returncode, 1)
self.assertIn("Error reading configuration: Unexpected character", str(deploy_process_execute.stderr))
self.assertIn(
"Unexpected character: 'm' at line 2 col 11",
str(deploy_process_execute.stderr),
"Should notify user of the parsing error.",
)

@parameterized.expand([("aws-serverless-function.yaml", "samconfig-tags-list.toml")])
def test_deploy_with_valid_config_tags_list(self, template_file, config_file):
Expand Down