Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIGRATION ISSUE: Missing presigned request functionality for SQS service #2793

Open
2 tasks done
avishay28 opened this issue Sep 16, 2024 · 1 comment
Open
2 tasks done
Assignees
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue queued This issues is on the AWS team's backlog v1-v2-inconsistency v1-v2-inconsistency Behavior has changed from v1 to v2, or feature is missing altogether

Comments

@avishay28
Copy link

avishay28 commented Sep 16, 2024

Pre-Migration Checklist

Go Version Used

Go 1.21

Describe the Migration Issue

Back in v1 I was able to obtain presign URL for SQS service ReceiveMessage operation, by calling ReceiveMessageRequest.
I couldn't find a way to do it SDK v2, the only way is to call ReceiveMessage and get the messages directly.

Code Comparison

In V1:

func (s *Service) getSignedRequestsURL(queueURL string, maxNumOfMessages, visibilityTimeout, waitTimeSeconds int64) (string, error) {
    req, _ := s.sqsService.ReceiveMessageRequest(&sqs.ReceiveMessageInput{
        QueueUrl:            aws.String(queueURL),
        MaxNumberOfMessages: aws.Int64(maxNumOfMessages),
        VisibilityTimeout:   aws.Int64(visibilityTimeout),
        WaitTimeSeconds:     aws.Int64(waitTimeSeconds),
    })

    exp := 20 * time.Minute
    signedURL, err := req.Presign(exp)
    if err != nil {
        return "", err
    }

    return signedURL, nil
} 

Observed Differences/Errors

Similar functionality not exist in V2.

Additional Context

No response

@avishay28 avishay28 added needs-triage This issue or PR still needs to be triaged. v1-v2-inconsistency v1-v2-inconsistency Behavior has changed from v1 to v2, or feature is missing altogether labels Sep 16, 2024
@RanVaknin RanVaknin self-assigned this Sep 24, 2024
@RanVaknin
Copy link
Contributor

Hi @avishay28,

We are going to do some work that would impact presigning in Go v2 so this will likely be covered by it. I don't think that the presigning behavior would mirror the v1 behavior, but we will consider this to maintain feature parity gaps between v1 and v2.

I'm adding this to our backlog.

Thanks for taking the time and reaching out.
Ran~

@RanVaknin RanVaknin added feature-request A feature should be added or improved. p2 This is a standard priority issue queued This issues is on the AWS team's backlog and removed needs-triage This issue or PR still needs to be triaged. labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue queued This issues is on the AWS team's backlog v1-v2-inconsistency v1-v2-inconsistency Behavior has changed from v1 to v2, or feature is missing altogether
Projects
None yet
Development

No branches or pull requests

2 participants