Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: LoadDefaultConfig should require passing context.Context during config loading. #819

Closed
skmcgrail opened this issue Oct 14, 2020 · 2 comments
Closed

config: LoadDefaultConfig should require passing context.Context during config loading. #819

skmcgrail opened this issue Oct 14, 2020 · 2 comments
Labels
automation-exempt feature-request A feature should be added or improved.
Milestone
v1.0 Release Cand...

Comments

@skmcgrail
Copy link
Member

Update config.LoadDefaultConfig to require context.Context during configuration loading.
@skmcgrail skmcgrail added the feature-request A feature should be added or improved. label Oct 14, 2020
@jasdel jasdel added this to the v1.0 Release Candidate milestone Nov 11, 2020
@skotambkar skotambkar mentioned this issue Dec 7, 2020
Merged
@skotambkar
Copy link
Contributor

Fixed in #951

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dependabot dependabot bot mentioned this issue Mar 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
automation-exempt feature-request A feature should be added or improved.
Projects
None yet
Milestone
v1.0 Release Candidate
Development

No branches or pull requests
3 participants
@skmcgrail @jasdel @skotambkar