Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

credentials/ec2rolecreds: New should not require an explict Options value to be passed to the function. #940

Closed
skmcgrail opened this issue Dec 1, 2020 · 1 comment · Fixed by #946
Labels
breaking-change Issue requires a breaking change to remediate.

Comments

@skmcgrail
Copy link
Member

ec2rolecreds.New requires that an Options value be passed to the constructor function. Since the constructor does not require any explicit arguments to be populated in options this function should be updated to only take a list of functions that mutate the options. This keeps the design consistent with other credential providers like endpointcreds.New which take the explicit arguments required by the provider, and then the functions that mutate the options.

@skmcgrail skmcgrail added the breaking-change Issue requires a breaking change to remediate. label Dec 1, 2020
@skmcgrail skmcgrail added this to the v1.0 Release Candidate milestone Dec 1, 2020
@github-actions
Copy link

github-actions bot commented Dec 7, 2020

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Issue requires a breaking change to remediate.
Projects
None yet
1 participant