service/s3/s3manager: adding cleanup function to batch objects #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xibz
force-pushed
the
s3manager_batch_after
branch
from
737efa6 to
d014570
Compare
jasdel
suggested changes
Jun 27, 2017
service/s3/s3manager/batch.go
Outdated
| key, | ||
| } | ||
| } | ||
|
|
||
| func (err *Error) Error() string { | ||
| return err.OrigErr.Error() |
There was a problem hiding this comment.
It would be helpful for the Error message to include the bucket and object key that the error failed on.
service/s3/s3manager/batch.go
Outdated
| @@ -382,4 +396,6 @@ func (batcher *UploadObjectsIterator) UploadObject() BatchUploadObject { | |||
| // BatchUploadObject contains all necessary information to run a batch operation once. | |||
| type BatchUploadObject struct { | |||
| Object *UploadInput | |||
| // After will run after each iteration during the batch process | |||
There was a problem hiding this comment.
I'll clarify this statement to stay after the object has been attempted to be uploaded. Regardless of success/failure.
Same for the other After functions
service/s3/s3manager/batch_test.go
Outdated
| downloader := NewDownloaderWithClient(svc) | ||
| deleter := NewBatchDeleteWithClient(svc) | ||
|
|
||
| iter := &testAfterIter{} |
There was a problem hiding this comment.
should create a new iterator for each test case to prevent pollution. Sharing the iterator value can hide or introduce bugs in the test.
service/s3/s3manager/batch_test.go
Outdated
| } | ||
|
|
||
| func (iter *testAfterIter) Next() bool { | ||
| next := (iter.index & 1) == 0 |
There was a problem hiding this comment.
Nit this will only wouldn't this be similar to just do something like the following, or change from an index, to a boolean flag.
func (iter *testAfterIter) Next() bool {
defer func() { iter.index++ }
return iter.index == 0
}
xibz
force-pushed
the
s3manager_batch_after
branch
from
d014570 to
30a00d3
Compare
jasdel
approved these changes
Jun 30, 2017
Merged
diehlaws
added
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.