Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create EnvProviderName constant. #1531

Merged
merged 2 commits into from
Sep 19, 2017
Merged

Create EnvProviderName constant. #1531

merged 2 commits into from
Sep 19, 2017

Conversation

elliott-beach
Copy link
Contributor

Fixes #1444 by moving the "EnvConfigCredentials" string literal into the EnvProviderName constant.

jasdel
jasdel approved these changes Sep 19, 2017
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jasdel
Copy link
Contributor

jasdel commented Sep 19, 2017

Thanks for putting together this PR @e-beach. The change looks good. I'll go ahead and merge this in.

@jasdel jasdel merged commit 454fa19 into aws:master Sep 19, 2017
jasdel added a commit that referenced this pull request Sep 19, 2017
@jasdel
Add #1531 to change log.
8c31c18
@awstools awstools mentioned this pull request Sep 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasdel jasdel jasdel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliott-beach @jasdel