Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for credential_source in shared config #1901

Closed
haines opened this issue Apr 18, 2018 · 5 comments
Closed

Support for credential_source in shared config #1901

haines opened this issue Apr 18, 2018 · 5 comments
Labels
feature-request A feature should be added or improved.

Comments

@haines
Copy link

haines commented Apr 18, 2018

I'd like to use credential_source in shared config files, but it doesn't seem to be supported by this sdk yet. Could I put in a feature request please?

Thanks!

@jasdel jasdel added the feature-request A feature should be added or improved. label Apr 20, 2018
@xibz
Copy link
Contributor

xibz commented Apr 30, 2018

Hello @haines, thank you for reaching out to us. This would be a great feature to have in the SDK and we would be glad to accept any PRs :)!

@ColinHebert
Copy link

FYI this is the boto version of the changes required here:
boto/botocore#1313

@hoshsadiq
Copy link

#2201 got merged which adds support for credential_source

@xibz xibz closed this as completed Oct 12, 2018
@xibz
Copy link
Contributor

xibz commented Oct 12, 2018

Thanks @hoshsadiq!

As @hoshsadiq already mentioned, #2201 now supports credential_source. Please let us know if there are any issues or questions with #2201.

@gasamoma
Copy link

So, I just implemented an ECS cluster that runs with terraform that uses the AWS go sdk, I have the following config:
~/.aws/config

[profile mosecurity-production]
region=us-east-1
output=json
role_arn=arn:aws:iam::12345678:role/Deployment
credential_source=EcsContainer

[profile mo-production]
region=us-east-1
output=json
source_profile=mosecurity-production
role_arn=arn:aws:iam::123456:role/Deployment

I recreated the environment on the EC2 instance and it works the confif is the following
~/.aws/config

[profile mosecurity-production]
region=us-east-1
output=json
role_arn=arn:aws:iam::12345678:role/Deployment
credential_source=Ec2InstanceMetadata

[profile mo-production]
region=us-east-1
output=json
source_profile=mosecurity-production
role_arn=arn:aws:iam::123456:role/Deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

6 participants