Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing S3 Bucket Canned ACLs #2683

Closed
ricoli opened this issue Jul 4, 2019 · 4 comments
Closed

Missing S3 Bucket Canned ACLs #2683

ricoli opened this issue Jul 4, 2019 · 4 comments
Labels
bug This issue is a bug. closed-for-staleness service-api This issue is due to a problem in a service API, not the SDK implementation.

Comments

@ricoli
Copy link

ricoli commented Jul 4, 2019

Please fill out the sections below to help us address your issue.

Version of AWS SDK for Go?

1.20.15

Version of Go (go version)?

What issue did you see?

There are missing BucketCannedACLs in the API definition (https://github.com/aws/aws-sdk-go/blob/v1.20.15/models/apis/s3/2006-03-01/api-2.json#L1071-L1079) - expected to see all the ones mentioned in https://docs.aws.amazon.com/AmazonS3/latest/dev/acl-overview.html#canned-acl

Steps to reproduce

If you have an runnable example, please include it.

@ricoli
Copy link
Author

ricoli commented Jul 4, 2019

Linking terraform-linters/tflint#341 (comment) to this

@diehlaws diehlaws self-assigned this Jul 8, 2019
@diehlaws diehlaws added the service-api This issue is due to a problem in a service API, not the SDK implementation. label Jul 8, 2019
@diehlaws
Copy link
Contributor

diehlaws commented Jul 8, 2019

Hi @ricoli, thanks for reaching out to us about this. The canned Bucket ACLs that are missing in the API model but present in the documentation page you linked work as expected in the ACL field of a CreateBucketInput or PutBucketAclInput struct.

Since the API definition to which you've linked is provided to us by the S3 team, any changes we make to it from here would be overwritten on the next release. That being said, I can see in the referenced pull request the reasoning behind opening this issue so I have reach out to the S3 team internally to have the API model updated to more accurately reflect reality. Once the S3 team responds to my request I will update the issue accordingly.

@ricoli
Copy link
Author

ricoli commented Jul 9, 2019

Thank you very much @diehlaws, this will certainly benefit validation projects such as tflint :)

@github-actions
Copy link

We have noticed this issue has not received attention in 1 year. We will close this issue for now. If you think this is in error, please feel free to comment and reopen the issue.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. closed-for-staleness service-api This issue is due to a problem in a service API, not the SDK implementation.
Projects
None yet
Development

No branches or pull requests

3 participants