Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing enum value "initiatingRequest" for transit gateway peering attachment #3284

Closed
3 tasks done
j-nix opened this issue Apr 24, 2020 · 4 comments
Closed
3 tasks done
Labels
bug This issue is a bug. service-api This issue is due to a problem in a service API, not the SDK implementation.

Comments

@j-nix
Copy link

j-nix commented Apr 24, 2020

Confirm by changing [ ] to [x] below to ensure that it's a bug:

Describe the bug
When awaiting a state change on a transit gateway peering attachment, AWS returns the state initiatingRequest, but the SDK doesn't contain an enum value for this.

File : https://github.com/aws/aws-sdk-go/blob/master/service/ec2/api.go Line 112270

Version of AWS SDK for Go?
Example: v1.30.12

Version of Go (go version)?
go 1.13.5

To Reproduce (observed behavior)
Create a transit gateway peering attachment, and poll AWS API for the state, it will return initiatingRequest, rather than initiating - as is correct for a transit gateway attachment, not a peering attachment.

Noticed when working on the terraform provider code for this:
hashicorp/terraform-provider-aws#11162

Expected behavior
Enum should exist for this state :

TransitGatewayAttachmentStateInitiatingRequest = "initiatingRequest"

Additional context
Add any other context about the problem here.

@j-nix j-nix added the needs-triage This issue or PR still needs to be triaged. label Apr 24, 2020
@diehlaws diehlaws self-assigned this Apr 27, 2020
@diehlaws diehlaws added service-api This issue is due to a problem in a service API, not the SDK implementation. and removed needs-triage This issue or PR still needs to be triaged. labels Apr 27, 2020
@diehlaws
Copy link
Contributor

Hi @j-nix, thanks for bringing this to our attention. It looks like this is a modeling issue for the service - the TransitGatewayAttachmentState member of the EC2 API model is missing the described state which is preventing this state from being populated during the code generation for our EC2 client. I've reached out to the EC2 team about this internally to have the API model include this state, once I hear back from them on this I'll update the issue accordingly.

@j-nix
Copy link
Author

j-nix commented Apr 28, 2020

@diehlaws thanks for clarifying how this is generated - i'll close the PR for this and keep the issue open for your updates.

@diehlaws diehlaws added the bug This issue is a bug. label Aug 7, 2020
@diehlaws diehlaws removed their assignment Aug 26, 2020
@skmcgrail
Copy link
Member

This has been fixed, please update to the latest SDK version.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. service-api This issue is due to a problem in a service API, not the SDK implementation.
Projects
None yet
Development

No branches or pull requests

3 participants