service/s3: Add support for accelerate with dual stack #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for using S3 accelerate with Dualstack IPv4 with IPv6. To
enable Dualstack with accelerate set the `Config.UseDualstack` and
`Config.S3UseAccelerate`.
```go
sess := session.New()
svc := s3.New(sess, &aws.Config{
S3UseAccelerate: aws.Bool(true),
UseDualStack: aws.Bool(true),
})
result, err := svc.GetObject(&s3.GetObjectInput{
Bucket: aws.String("my_bucket"),
Key: aws.String("my_key"),
})
// Request made to:
// https://my_bucket.s3-accelerate.dualstack.amazonaws.com/my_key
```
|
LGTM |
jasdel
added a commit
to jasdel/aws-sdk-go
that referenced
this pull request
Oct 13, 2016
Service Model Updates --- * `service/acm`: Update service API, and documentation. * This change allows users to import third-party SSL/TLS certificates into ACM. * `service/elasticbeanstalk`: Update service API, documentation, and pagination. * Elastic Beanstalk DescribeApplicationVersions API is being updated to support pagination. * `service/gamelift`: Update service API, and documentation. * New APIs to protect game developer resource (builds, alias, fleets, instances, game sessions and player sessions) against abuse. SDK Features --- * `service/s3`: Add support for accelerate with dualstack (aws#887)
Merged
jasdel
added a commit
that referenced
this pull request
Oct 13, 2016
Service Model Updates --- * `service/acm`: Update service API, and documentation. * This change allows users to import third-party SSL/TLS certificates into ACM. * `service/elasticbeanstalk`: Update service API, documentation, and pagination. * Elastic Beanstalk DescribeApplicationVersions API is being updated to support pagination. * `service/gamelift`: Update service API, and documentation. * New APIs to protect game developer resource (builds, alias, fleets, instances, game sessions and player sessions) against abuse. SDK Features --- * `service/s3`: Add support for accelerate with dualstack (#887)
skotambkar
pushed a commit
to skotambkar/aws-sdk-go
that referenced
this pull request
May 20, 2021
codegen: Add support for list and maps generated as value members instead of pointer
skotambkar
pushed a commit
to skotambkar/aws-sdk-go
that referenced
this pull request
May 20, 2021
Fixes up documentation comments that were missed in aws#887
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for using S3 accelerate with dual stack IPv4 with IPv6. To
enable dual stack with accelerate set the
Config.UseDualstackandConfig.S3UseAccelerate.