Skip to content

Commit b44f83d

Browse files
committed
V4Context is not Immutable
1 parent 8c19a19 commit b44f83d

File tree

1 file changed

+4
-2
lines changed
  • core/http-auth-aws/src/main/java/software/amazon/awssdk/http/auth/aws/internal/signer

1 file changed

+4
-2
lines changed

core/http-auth-aws/src/main/java/software/amazon/awssdk/http/auth/aws/internal/signer/V4Context.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,17 @@
1515

1616
package software.amazon.awssdk.http.auth.aws.internal.signer;
1717

18-
import software.amazon.awssdk.annotations.Immutable;
1918
import software.amazon.awssdk.annotations.SdkInternalApi;
2019
import software.amazon.awssdk.http.SdkHttpRequest;
2120

2221
/**
2322
* A container for data produced during and as a result of the SigV4 request signing process.
2423
*/
2524
@SdkInternalApi
26-
@Immutable
25+
// TODO(sra-identity-auth): This is currently not @Immutable because signedRequest is a Builder. Is Builder needed? If it could
26+
// hold reference to SdkHttpRequest instead, this class would be @Immutable.
27+
// TODO(sra-identity-auth): Consider if we can rename this to convey something more. maybe,
28+
// V4RequestSigningResult/V4RequestSigningResultData? Note there is V4aContext similarly.
2729
public final class V4Context {
2830
private final String contentHash;
2931
private final byte[] signingKey;

0 commit comments

Comments
 (0)