Skip to content

Commit fb7eca9

Browse files
committed
Uncomment previously disabled AsyncHttpChecksumIntegrationTest
1 parent e8c74e0 commit fb7eca9

File tree

2 files changed

+2
-13
lines changed

2 files changed

+2
-13
lines changed

core/sdk-core/src/main/java/software/amazon/awssdk/core/internal/http/pipeline/stages/HttpChecksumStage.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,8 @@ public SdkHttpFullRequest.Builder execute(SdkHttpFullRequest.Builder request, Re
7575
return request;
7676
}
7777

78-
// If SRA is enabled, we skip flexible checksum in header
79-
// TODO(post-sra-identity-auth): we should remove this after SRA is fully released
78+
// If SRA is enabled, we skip flexible checksum in header, as it is not supported in the HttpSigner right now
79+
// TODO: we should remove this after it is supported
8080
if (sraSigningEnabled(context)) {
8181
return request;
8282
}

services/s3/src/it/java/software/amazon/awssdk/services/s3/checksum/AsyncHttpChecksumIntegrationTest.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@
4949
import software.amazon.awssdk.services.s3.model.PutObjectRequest;
5050
import software.amazon.awssdk.services.s3.model.PutObjectResponse;
5151
import software.amazon.awssdk.services.s3.utils.CaptureChecksumValidationInterceptor;
52-
import software.amazon.awssdk.services.s3.utils.ChecksumUtils;
5352
import software.amazon.awssdk.testutils.RandomTempFile;
5453

5554
public class AsyncHttpChecksumIntegrationTest extends S3IntegrationTestBase {
@@ -234,11 +233,6 @@ void asyncValidSignedTrailerChecksumCalculatedBySdkClient() {
234233
assertThat(response).isEqualTo("Hello world");
235234
}
236235

237-
/**
238-
* If http is used, payload signing will be enforced, but it's not currently supported in async path
239-
* TODO: re-enable it once it's supported
240-
*/
241-
@Disabled("Payload signing is not supported for S3 async client")
242236
@Test
243237
public void putObject_with_bufferCreatedFromEmptyString() {
244238

@@ -261,11 +255,6 @@ public void putObject_with_bufferCreatedFromEmptyString() {
261255
assertThat(response).isEqualTo("");
262256
}
263257

264-
/**
265-
* If http is used, payload signing will be enforced, but it's not currently supported in async path
266-
* TODO: re-enable it once it's supported
267-
*/
268-
@Disabled("Payload signing is not supported for S3 async client")
269258
@Test
270259
public void putObject_with_bufferCreatedFromZeroCapacityByteBuffer() {
271260
ByteBuffer content = ByteBuffer.allocate(0);

0 commit comments

Comments
 (0)