Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxy config option to TransferManager #3262

Closed
2 tasks
saso5 opened this issue Jun 22, 2022 · 1 comment · Fixed by #3824
Closed
2 tasks

Add proxy config option to TransferManager #3262

saso5 opened this issue Jun 22, 2022 · 1 comment · Fixed by #3824
Labels
dependencies This issue is a problem in a dependency. feature-request A feature should be added or improved. p3 This is a minor priority issue transfer-manager

Comments

@saso5
Copy link

saso5 commented Jun 22, 2022

Describe the feature

Add a proxy configuration option to the TransferManager S3ClientConfiguration as it is available in all other clients.

Use Case

Our service deployment need a programmatic and dynamic way of setting the proxy host as we are behind a firewall.
Current workaround is to set the HTTPS_PROXY env variable (FYI: this not documented aware or at least I didn't find any reference) but it's not ideal as it cannot be changed dynamically in a easy way.

Proposed Solution

I've opened a FR for the CRT client awslabs/aws-crt-java#502

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Java SDK version used

s3-transfer-manager:2.17.176-PREVIEW

JDK version used

JDK 11

Operating System and version

Windows 10
@saso5 saso5 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 22, 2022
@zoewangg zoewangg added transfer-manager dependencies This issue is a problem in a dependency. and removed needs-triage This issue or PR still needs to be triaged. labels Jun 22, 2022
@yasminetalby yasminetalby added the p3 This is a minor priority issue label Nov 28, 2022
@zoewangg zoewangg mentioned this issue Mar 9, 2023
Merged
12 tasks
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies This issue is a problem in a dependency. feature-request A feature should be added or improved. p3 This is a minor priority issue transfer-manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose S3CrtHttpConfiguration aws/aws-sdk-java-v2
3 participants
@saso5 @zoewangg @yasminetalby