[WIP] Remove echo command #6506
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagnir
force-pushed
the
dongie/fix-buildspec
branch
from
ae45380 to
7c629b6
Compare
dagnir
commented
Oct 23, 2025
Comment on lines
-25
to
-35
| BASE_REF=${{ github.base_ref || github.event.merge_group.base_ref || github.ref }} | ||
| BASE_REF=${BASE_REF#refs/heads/} | ||
| git fetch origin "$BASE_REF" --depth 1 | ||
| CHANGED_FILES=$(git diff origin/"$BASE_REF" --name-only) | ||
| if echo "$CHANGED_FILES" | grep -q -E '^core/|^services/s3/|^services-custom/s3-transfer-manager/|^http-client-spi/|^http-clients/'; then | ||
| echo "Detected changes in S3, HTTP client, or core modules" | ||
| echo "has_s3_related_changes=true" >> $GITHUB_OUTPUT | ||
| else | ||
| echo "No changes detected in S3, HTTP client, or core modules" | ||
| echo "has_s3_related_changes=false" >> $GITHUB_OUTPUT | ||
| fi |
There was a problem hiding this comment.
Just to force s3-tests to run
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License