Skip to content

Commit 7d03c13

Browse files
committed
fix: make removeGlobalModule importType independent
1 parent 8dc52b9 commit 7d03c13

File tree

2 files changed

+5
-15
lines changed

2 files changed

+5
-15
lines changed

src/transforms/v2-to-v3/modules/removeGlobalModule.ts

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,12 @@ import { PACKAGE_NAME } from "../config";
44
import { removeImportDefault } from "./removeImportDefault";
55
import { removeImportEquals } from "./removeImportEquals";
66
import { removeRequireIdentifier } from "./removeRequireIdentifier";
7-
import { ImportType } from "./types";
8-
9-
export interface RemoveGlobalModuleOptions {
10-
importType: ImportType;
11-
v2GlobalName?: string;
12-
}
137

148
// Removes the import of "aws-sdk" if it's not used.
159
export const removeGlobalModule = (
1610
j: JSCodeshift,
1711
source: Collection<unknown>,
18-
{ importType, v2GlobalName }: RemoveGlobalModuleOptions
12+
v2GlobalName?: string
1913
) => {
2014
if (!v2GlobalName) return;
2115

@@ -24,12 +18,8 @@ export const removeGlobalModule = (
2418
// Only usage is import/require.
2519
if (identifierUsages.size() === 1) {
2620
const defaultOptions = { localName: v2GlobalName, sourceValue: PACKAGE_NAME };
27-
if (importType === ImportType.REQUIRE) {
28-
removeRequireIdentifier(j, source, defaultOptions);
29-
} else if (importType === ImportType.IMPORT_EQUALS) {
30-
removeImportEquals(j, source, defaultOptions);
31-
} else {
32-
removeImportDefault(j, source, defaultOptions);
33-
}
21+
removeRequireIdentifier(j, source, defaultOptions);
22+
removeImportEquals(j, source, defaultOptions);
23+
removeImportDefault(j, source, defaultOptions);
3424
}
3525
};

src/transforms/v2-to-v3/transformer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ const transformer = async (file: FileInfo, api: API) => {
9999
replaceAwsConfig(j, source, v2GlobalName);
100100
replaceAwsIdentity(j, source, { v2GlobalName, importType });
101101
replaceAwsUtilFunctions(j, source, v2GlobalName);
102-
removeGlobalModule(j, source, { v2GlobalName, importType });
102+
removeGlobalModule(j, source, v2GlobalName);
103103

104104
return source.toSource();
105105
};

0 commit comments

Comments
 (0)