[Bug]: No files selected, nothing to do. Version 1.0.1

[abu450]

Self-service

• I'd be willing to implement a fix

Describe the bug

Date: 2024-02-20T08:42:32.865Z
Tried the command with both relative and absolute paths. It was working till two days ago, but today, it just doesn't find the file and shows the:
No files selected, nothing to do.
All done.
Results:
0 errors
0 unmodified
0 skipped
0 ok
Time elapsed: 0.001seconds

Steps to reproduce

Run:
npx aws-sdk-js-codemod@latest -t v2-to-v3 PATH

Observed behavior

No files selected, nothing to do.
All done.
Results:
0 errors
0 unmodified
0 skipped
0 ok
Time elapsed: 0.001seconds

Expected behavior

Does the migration

Environment

aws-sdk-js-codemod@latest

Additional context

No response

[abu450]

Just tried Version 1.0.0 instead of latest(1.0.1) and that worked

[trivikr]

Verified that this issue exists with v1.0.1

$ cat example.ts
import AWS from "aws-sdk";
const client = new AWS.DynamoDB();
const response = await client.listTables({}).promise();

$ npx aws-sdk-js-codemod@1.0.1 -t v2-to-v3 example.ts
Need to install the following packages:
aws-sdk-js-codemod@1.0.1
Ok to proceed? (y) y

╔════════════════════════════════════════════════════════╗
║ Please review the code change thoroughly for required  ║
║ functionality before deploying it to production.       ║
║                                                        ║
║ If the transformation is not complete or is incorrect, ║
║ please report the issue on GitHub.                     ║
╚════════════════════════════════════════════════════════╝

No files selected, nothing to do. 
All done. 
Results: 
0 errors
0 unmodified
0 skipped
0 ok
Time elapsed: 0.001seconds

[trivikr]

The v1.0.1 updated jscodeshift from v0.15.0 to v0.15.1
Release Notes https://github.com/aws/aws-sdk-js-codemod/releases/tag/v1.0.1

Looks like the PATH variable is not sent to the transformer post the update.
In addition to finding root cause and fixing this, a test will need to be written to ensure that files are always processed.

[trivikr]

Diff between jscodeshift v0.15.0 and v0.15.1

facebook/jscodeshift@v0.15.0...0.15.1

[trivikr]

The issue appears to be fix for respecting extensions in facebook/jscodeshift#562

The CLI succeeds if ts is explicitly passed as extensions

$ cat example.ts 
import AWS from "aws-sdk";
const client = new AWS.DynamoDB();
const response = await client.listTables({}).promise();

$ npx aws-sdk-js-codemod@1.0.1 -t v2-to-v3 --extensions=ts example.ts

╔════════════════════════════════════════════════════════╗
║ Please review the code change thoroughly for required  ║
║ functionality before deploying it to production.       ║
║                                                        ║
║ If the transformation is not complete or is incorrect, ║
║ please report the issue on GitHub.                     ║
╚════════════════════════════════════════════════════════╝

Processing 1 files... 
Spawning 1 workers...
Sending 1 files to free worker...
All done. 
Results: 
0 errors
0 unmodified
0 skipped
1 ok
Time elapsed: 0.252seconds

The issue with jscodeshift is that it sets js as default in extensions, and ignores ts files even if they're explicitly passed in PATH. We should report this upstream, but at the same time populate extensions option when calling jscodeshift to fix bug in aws-sdk-js-codemod.

[trivikr]

The bug reported upstream at facebook/jscodeshift#582

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.