fix: request/response object validation (#709)

aws · Jan 10, 2020 · f6f8256 · f6f8256
1 parent 5881e45
commit f6f8256
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/packages/protocol-http/src/httpRequest.ts b/packages/protocol-http/src/httpRequest.ts
@@ -43,6 +43,7 @@ export class HttpRequest implements HttpMessage, Endpoint {
 
   static isInstance(request: unknown): request is HttpRequest {
     //determine if request is a valid httpRequest
+    if (!request) return false;
     const req: any = request;
     return (
       "method" in req &&

diff --git a/packages/protocol-http/src/httpResponse.ts b/packages/protocol-http/src/httpResponse.ts
@@ -14,17 +14,19 @@ export class HttpResponse {
   public statusCode: number;
   public headers: HeaderBag;
   public body?: any;
-  private readonly isHttpResponse = true;
 
   constructor(options: HttpResponseOptions) {
     this.statusCode = options.statusCode;
     this.headers = options.headers || {};
     this.body = options.body;
   }
 
-  static isInstance(request: unknown): request is HttpResponse {
+  static isInstance(response: unknown): response is HttpResponse {
+    //determine if response is a valid HttpResponse
+    if (!response) return false;
+    const resp = response as any;
     return (
-      request !== undefined && (request as HttpResponse).isHttpResponse === true
+      typeof resp.statusCode === "number" && typeof resp.headers === "object"
     );
   }
 }