chore(credential-provider-node): do not set profile from env (#3481)

Author: trivikr

packages/credential-provider-node/src/defaultProvider.spec.ts

@@ -94,7 +94,7 @@ describe(defaultProvider.name, () => {
       expect(loadSharedConfigFiles).not.toHaveBeenCalled();
     });
 
-    it(`reads profile from env['${ENV_PROFILE}'], if not provided in init`, async () => {
+    it(`if env['${ENV_PROFILE}'] is set`, async () => {
       const ORIGINAL_ENV = process.env;
       process.env = {
         ...ORIGINAL_ENV,
@@ -107,7 +107,7 @@ describe(defaultProvider.name, () => {
 
       expect(fromEnv).not.toHaveBeenCalled();
       for (const fromFn of [fromSSO, fromIni, fromProcess, fromTokenFile, remoteProvider]) {
-        expect(fromFn).toHaveBeenCalledWith({ ...mockInit, profile: process.env[ENV_PROFILE] });
+        expect(fromFn).toHaveBeenCalledWith(mockInitWithoutProfile);
       }
 
       process.env = ORIGINAL_ENV;

packages/credential-provider-node/src/defaultProvider.ts

@@ -46,27 +46,19 @@ import { remoteProvider } from "./remoteProvider";
  */
 export const defaultProvider = (
   init: FromIniInit & RemoteProviderInit & FromProcessInit & FromSSOInit & FromTokenFileInit = {}
-): MemoizedProvider<Credentials> => {
-  const options = {
-    profile: process.env[ENV_PROFILE],
-    ...init,
-  };
-
-  const providerChain = chain(
-    ...(options.profile ? [] : [fromEnv()]),
-    fromSSO(options),
-    fromIni(options),
-    fromProcess(options),
-    fromTokenFile(options),
-    remoteProvider(options),
-    async () => {
-      throw new CredentialsProviderError("Could not load credentials from any providers", false);
-    }
-  );
-
-  return memoize(
-    providerChain,
+): MemoizedProvider<Credentials> =>
+  memoize(
+    chain(
+      ...(init.profile || process.env[ENV_PROFILE] ? [] : [fromEnv()]),
+      fromSSO(init),
+      fromIni(init),
+      fromProcess(init),
+      fromTokenFile(init),
+      remoteProvider(init),
+      async () => {
+        throw new CredentialsProviderError("Could not load credentials from any providers", false);
+      }
+    ),
     (credentials) => credentials.expiration !== undefined && credentials.expiration.getTime() - Date.now() < 300000,
     (credentials) => credentials.expiration !== undefined
   );
-};