Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move source files to "src" folder in clients #1306

Closed
trivikr opened this issue Jun 29, 2020 · 4 comments · Fixed by #2845
Closed

Move source files to "src" folder in clients #1306

trivikr opened this issue Jun 29, 2020 · 4 comments · Fixed by #2845
Labels
feature-request New feature or enhancement. May require GitHub community feedback.

Comments

@trivikr
Copy link
Member

trivikr commented Jun 29, 2020

Is your feature request related to a problem? Please describe.
The codegen clients and utility packages are developed independently, and lack standardization among them. The root TSConfig PR tries to standardize as explained in https://github.com/aws/aws-sdk-js-v3/pull/1297/files#r447210600

Describe the solution you'd like
This request is to move source files of clients in "src" folder in clients.
Most typescript projects store source files in src directory, and transpiled files in dist directory.

Describe alternatives you've considered
Retaining typescript files in root directory for clients
@trivikr trivikr added the feature-request New feature or enhancement. May require GitHub community feedback. label Jun 29, 2020
This was referenced Jul 29, 2020
Closed
Merged
@justingrant justingrant mentioned this issue Aug 25, 2020
Closed
This was referenced Oct 28, 2020
Closed
Closed
Closed
Closed
@github-actions
Copy link

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 30, 2021
@github-actions github-actions bot closed this as completed Jul 5, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2021
@trivikr trivikr reopened this Sep 16, 2021
@trivikr
Copy link
Member Author

trivikr commented Sep 16, 2021

This issue is being re-attempted as part of reducing install size.

This was referenced Sep 16, 2021
Merged
Closed
Closed
This was referenced Sep 28, 2021
Closed
Merged
Merged
@aws aws unlocked this conversation Sep 29, 2021
@trivikr trivikr mentioned this issue Sep 29, 2021
Merged
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request New feature or enhancement. May require GitHub community feedback.
Projects
None yet
Milestone
No milestone
1 participant
@trivikr