Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplify and add extensive tests got config-resolver #1401

Merged
merged 6 commits into from
Jul 28, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 28, 2020

Issue #, if available:
Internal issue JS-1834

Description of changes:
simplifies and add tests for config-resolver

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from alexforsyth July 28, 2020 06:22
@codecov-commenter
Copy link

Codecov Report

Merging #1401 into master will increase coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1401      +/-   ##
==========================================
+ Coverage   79.08%   79.48%   +0.39%     
==========================================
  Files         287      296       +9     
  Lines       11155    11385     +230     
  Branches     2360     2433      +73     
==========================================
+ Hits         8822     9049     +227     
- Misses       2333     2336       +3     
Impacted Files Coverage Δ
...al-provider-imds/src/remoteProvider/httpRequest.ts
...edential-provider-imds/src/fromInstanceMetadata.ts
...edential-provider-imds/src/remoteProvider/retry.ts
...dential-provider-imds/src/fromContainerMetadata.ts
...ider-imds/src/remoteProvider/RemoteProviderInit.ts
...rovider-imds/src/remoteProvider/ImdsCredentials.ts
.../credential-provider-process/dist/cjs/src/index.ts 92.50% <0.00%> (ø)
...s/remoteProvider/src/remoteProvider/httpRequest.ts 100.00% <0.00%> (ø)
...kages/shared-ini-file-loader/dist/cjs/src/index.ts 100.00% <0.00%> (ø)
...rovider-imds/dist/cjs/src/fromContainerMetadata.ts 100.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59948ee...bfc8f15. Read the comment docs.

@trivikr trivikr merged commit e03c974 into aws:master Jul 28, 2020
@trivikr trivikr deleted the config-resolver-tests branch July 28, 2020 17:09
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants