Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add filterSensitiveLog for Union types #1447

Merged
merged 3 commits into from
Aug 25, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 18, 2020

Issue #, if available:
Refs: smithy-lang/smithy-typescript#190

Description of changes:
adds filterSensitiveLog for Union types

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2020

Codecov Report

Merging #1447 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1447   +/-   ##
=======================================
  Coverage   79.80%   79.80%           
=======================================
  Files         298      298           
  Lines       11502    11502           
  Branches     2475     2475           
=======================================
  Hits         9179     9179           
  Misses       2323     2323           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c7f7ee...a208c87. Read the comment docs.

@trivikr trivikr force-pushed the union-filter-sensitive-log-codegen branch from f887594 to a208c87 Compare August 25, 2020 02:39
@trivikr trivikr marked this pull request as ready for review August 25, 2020 16:13
@trivikr
Copy link
Member Author

trivikr commented Aug 25, 2020

Marked as ready as smithy-typescript changes are merged in smithy-lang/smithy-typescript#190

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trivikr trivikr merged commit 2699f6a into aws:master Aug 25, 2020
@trivikr trivikr deleted the union-filter-sensitive-log-codegen branch August 25, 2020 16:18
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants