Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(util-dynamodb): unmarshall to convert DynamoDB record to JavaScript Object #1537

Merged
merged 32 commits into from
Sep 29, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 22, 2020

Issue #, if available:
Follow-up to #1531
This PR will be moved to ready for review, and base repository would be changed to master after #1531 is merged Done!

Description of changes:
convertToNative from DynamoDB AttributeValue type to JavaScript value

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as draft September 22, 2020 02:56
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2020

Codecov Report

Merging #1537 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1537      +/-   ##
==========================================
+ Coverage   79.80%   79.93%   +0.12%     
==========================================
  Files         298      306       +8     
  Lines       11502    11804     +302     
  Branches     2475     2527      +52     
==========================================
+ Hits         9179     9435     +256     
- Misses       2323     2369      +46     
Impacted Files Coverage Δ
...l_tests/aws-json/commands/EmptyOperationCommand.ts 90.00% <0.00%> (-10.00%) ⬇️
...ts/aws-query/commands/NoInputAndNoOutputCommand.ts 90.00% <0.00%> (-10.00%) ⬇️
.../aws-restxml/commands/NoInputAndNoOutputCommand.ts 90.00% <0.00%> (-10.00%) ⬇️
...aws-restjson/commands/NoInputAndNoOutputCommand.ts 90.00% <0.00%> (-10.00%) ⬇️
protocol_tests/aws-ec2/commands/XmlBlobsCommand.ts 95.00% <0.00%> (-5.00%) ⬇️
protocol_tests/aws-ec2/commands/XmlEnumsCommand.ts 95.00% <0.00%> (-5.00%) ⬇️
protocol_tests/aws-ec2/commands/XmlListsCommand.ts 95.00% <0.00%> (-5.00%) ⬇️
...rotocol_tests/aws-query/commands/XmlMapsCommand.ts 95.00% <0.00%> (-5.00%) ⬇️
...otocol_tests/aws-query/commands/XmlBlobsCommand.ts 95.00% <0.00%> (-5.00%) ⬇️
...otocol_tests/aws-query/commands/XmlEnumsCommand.ts 95.00% <0.00%> (-5.00%) ⬇️
... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04b219a...1c8a9d6. Read the comment docs.

@trivikr trivikr changed the title feat(util-dynamodb): convertToNative from DynamoDB AttributeValue type to JavaScript value feat(util-dynamodb): unmarshall to convert DynamoDB record to JavaScript Object Sep 23, 2020
reason: user may only have read permission on DynamoDB values,
and can't modify already stored values.
reason: users will be able to differentiate between string and NumberValue
while processing the returned value
@trivikr trivikr force-pushed the util-dynamodb-convertOutput branch from f9d4c1d to 5872c65 Compare September 28, 2020 18:13
@trivikr trivikr changed the base branch from util-dynamodb to master September 28, 2020 18:14
@trivikr trivikr marked this pull request as ready for review September 28, 2020 18:27
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@trivikr trivikr merged commit f09e0da into aws:master Sep 29, 2020
@trivikr trivikr deleted the util-dynamodb-convertOutput branch September 29, 2020 16:43
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants