-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(util-dynamodb): unmarshall to convert DynamoDB record to JavaScript Object #1537
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1537 +/- ##
==========================================
+ Coverage 79.80% 79.93% +0.12%
==========================================
Files 298 306 +8
Lines 11502 11804 +302
Branches 2475 2527 +52
==========================================
+ Hits 9179 9435 +256
- Misses 2323 2369 +46
Continue to review full report at Codecov.
|
reason: user may only have read permission on DynamoDB values, and can't modify already stored values.
reason: users will be able to differentiate between string and NumberValue while processing the returned value
f9d4c1d
to
5872c65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue #, if available:
Follow-up to #1531
This PR will be moved to ready for review, and base repository would be changed to master after #1531 is mergedDone!Description of changes:
convertToNative from DynamoDB AttributeValue type to JavaScript value
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.