Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(abort-controller): make AbortSignal WHATWG Spec compliant #1699

Merged
merged 2 commits into from
Nov 19, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 19, 2020

Issue #, if available:
Fixes: #1159

Description of changes:
Makes AbortSignal WHATWG Spec compliant.

Verified that no errors were thrown with the following code:

const { DynamoDBClient, ListTablesCommand } = require("@aws-sdk/client-dynamodb");

// Commenting the import verifies the fix with AbortController Web API.
// Uncommenting the import verifies the fix with abort-controller npm package.
// const { AbortController } = require("abort-controller");

const abortSignal = new AbortController().signal;
const client = new DynamoDBClient({});

client.send(
  new ListTablesCommand({}),
  { abortSignal }
);

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after build passes

@codecov-io
Copy link

Codecov Report

Merging #1699 (e238aee) into master (de75f7e) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1699      +/-   ##
==========================================
- Coverage   79.77%   79.76%   -0.02%     
==========================================
  Files         325      329       +4     
  Lines       12087    12574     +487     
  Branches     2553     2671     +118     
==========================================
+ Hits         9643    10030     +387     
- Misses       2444     2544     +100     
Impacted Files Coverage Δ
...tocol_tests/aws-restxml/commands/XmlMapsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlBlobsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlEnumsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlListsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...col_tests/aws-restjson/commands/JsonMapsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonBlobsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonEnumsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonListsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...tests/aws-restxml/commands/XmlAttributesCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...tests/aws-restxml/commands/XmlNamespacesCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
... and 109 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f61bb...e238aee. Read the comment docs.

@trivikr trivikr merged commit 723ec4d into aws:master Nov 19, 2020
@trivikr trivikr deleted the fix-AbortController-spec branch November 19, 2020 18:39
@github-actions
Copy link

github-actions bot commented Jan 9, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AbortSignal type doesn't conform to WHATWG API
3 participants