Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@aws-sdk/client-api-gateway: CreateApiKeyRequest.name disappeared in rc.4 #1714

Closed
mfogel opened this issue Nov 23, 2020 · 4 comments · Fixed by #1774
Closed

@aws-sdk/client-api-gateway: CreateApiKeyRequest.name disappeared in rc.4 #1714

mfogel opened this issue Nov 23, 2020 · 4 comments · Fixed by #1774
Assignees
Labels
bug This issue is a bug. High Priority

Comments

@mfogel
Copy link

mfogel commented Nov 23, 2020

In fdd0ddf the optional field name was removed from the CreateApiKeyRequest interface for the api-gateway client (looking at clients/client-api-gateway/models/models_0.ts). I'm guessing this was unintentional, but if I'm missing something, please let me know.

Thanks for your work on this rebuild of the sdk, much appreciated!

@AllanZhengYP AllanZhengYP added the investigating Issue is being investigated and/or work is in progress to resolve the issue. label Nov 23, 2020
@AllanZhengYP
Copy link
Contributor

I can confirm the field is not removed by the service model, but it was removed in rc.7 release

@AllanZhengYP AllanZhengYP added the bug This issue is a bug. label Nov 23, 2020
@AllanZhengYP AllanZhengYP assigned trivikr and unassigned AllanZhengYP Dec 8, 2020
@trivikr
Copy link
Member

trivikr commented Dec 8, 2020

This is caused by CreateApiKeyRequest.name being removed from model using which client is built.

@trivikr
Copy link
Member

trivikr commented Dec 8, 2020

The model for reference:

"com.amazonaws.apigateway#CreateApiKeyRequest": {
"type": "structure",
"members": {
"description": {
"target": "com.amazonaws.apigateway#String",
"traits": {
"smithy.api#documentation": "<p>The description of the <a>ApiKey</a>.</p>"
}
},
"customerId": {
"target": "com.amazonaws.apigateway#String",
"traits": {
"smithy.api#documentation": "<p>An AWS Marketplace customer identifier , when integrating with the AWS SaaS Marketplace.</p>"
}
},
"stageKeys": {
"target": "com.amazonaws.apigateway#ListOfStageKeys",
"traits": {
"smithy.api#documentation": "<p>DEPRECATED FOR USAGE PLANS - Specifies stages associated with the API key.</p>"
}
},
"value": {
"target": "com.amazonaws.apigateway#String",
"traits": {
"smithy.api#documentation": "<p>Specifies a value of the API key.</p> <!-- Why is this declared as the input to create an API key? As a form of copying an existing key value into a new API key? -->"
}
},
"tags": {
"target": "com.amazonaws.apigateway#MapOfStringToString",
"traits": {
"smithy.api#documentation": "<p>The key-value map of strings. The valid character set is [a-zA-Z+-=._:/]. The tag key can be up to 128 characters and must not start with <code>aws:</code>. The tag value can be up to 256 characters.</p>"
}
},
"enabled": {
"target": "com.amazonaws.apigateway#Boolean",
"traits": {
"smithy.api#documentation": "<p>Specifies whether the <a>ApiKey</a> can be used by callers.</p>"
}
},
"generateDistinctId": {
"target": "com.amazonaws.apigateway#Boolean",
"traits": {
"smithy.api#documentation": "<p>Specifies whether (<code>true</code>) or not (<code>false</code>) the key identifier is distinct from the created API key value. This parameter is deprecated and should not be used.</p>"
}
}
},
"traits": {
"smithy.api#documentation": "<p>Request to create an <a>ApiKey</a> resource.</p>"
}
},

@trivikr trivikr added High Priority and removed investigating Issue is being investigated and/or work is in progress to resolve the issue. labels Dec 8, 2020
@github-actions
Copy link

github-actions bot commented Jan 8, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. High Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants