fix(clients): populate sdkId in serviceId and default to use arnNamespace as signingName #1786
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1765
Description of changes:
The previous change #1765 put arnNamespace in serviceId client config, and use it as fallback when a service doesn't specify a signing name in its
endpoints.json
credentialScope. It fixes the issue but theserviceId
config is not correct. Right now theserviceId
is generated from arnNamespace in the Smithy model, but it can be different from the actual service id. It may result unexpected results in metrics.This change moves the fallback-to-arnNamespace logic to
endpoints.ts
: every service hasarnNamespace
as default signingName. If they have a different signing name in itsendpoints.json
credentialScope, they will use that instead. NowserviceId
client config can be changed to actual service id because it doesn't need to provide the signing name information.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.