Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clients): remove retry headers for several services #1789

Merged
merged 2 commits into from
Dec 21, 2020

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Dec 14, 2020

ConnectParticipant, IoT Data Plane, IoT, Pinpoint SMS Voice, QLDB doesn't
support retry headers per their CORS config. So remove the support for
these service to unblock the browser usage

Integration Test

request headers:
✅ ConnectParticipant
✅ IoT Data Plane
✅ IoT
✅ Pinpoint SMS Voice
✅ QLDB

Request header
Issue #, if available:
Fixes #1376

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Dec 14, 2020

Codecov Report

Merging #1789 (98d4a7a) into master (de75f7e) will decrease coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1789      +/-   ##
==========================================
- Coverage   79.77%   79.25%   -0.53%     
==========================================
  Files         325      365      +40     
  Lines       12087    15072    +2985     
  Branches     2553     3206     +653     
==========================================
+ Hits         9643    11945    +2302     
- Misses       2444     3127     +683     
Impacted Files Coverage Δ
protocol_tests/aws-json/models/models_0.ts 79.36% <0.00%> (-20.64%) ⬇️
protocol_tests/aws-restjson/models/models_0.ts 89.43% <0.00%> (-10.57%) ⬇️
...rotocol_tests/aws-restxml/protocols/Aws_restXml.ts 64.10% <0.00%> (-2.15%) ⬇️
...ackages/node-http-handler/src/node-http-handler.ts 98.00% <0.00%> (-2.00%) ⬇️
packages/middleware-sdk-sqs/src/send-message.ts 86.66% <0.00%> (-0.84%) ⬇️
protocol_tests/aws-query/protocols/Aws_query.ts 66.34% <0.00%> (-0.38%) ⬇️
...kages/middleware-sdk-sqs/src/send-message-batch.ts 92.30% <0.00%> (-0.29%) ⬇️
...kages/fetch-http-handler/src/fetch-http-handler.ts 9.30% <0.00%> (-0.23%) ⬇️
protocol_tests/aws-ec2/protocols/Aws_ec2.ts 66.93% <0.00%> (-0.01%) ⬇️
packages/url-parser-node/src/index.ts 100.00% <0.00%> (ø)
... and 183 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0011af2...98d4a7a. Read the comment docs.

@trivikr trivikr changed the title fix(clients-*): remove retry headers for serveral services fix(clients-*): remove retry headers for several services Dec 14, 2020
@trivikr trivikr changed the title fix(clients-*): remove retry headers for several services fix(clients): remove retry headers for several services Dec 14, 2020
@AllanZhengYP AllanZhengYP marked this pull request as ready for review December 15, 2020 01:51
@AllanZhengYP AllanZhengYP force-pushed the remove-cors-headers branch 2 times, most recently from 98d4a7a to f8414a2 Compare December 19, 2020 01:42
ConnectParticipant, IoT Data Plane, IoT, Pinpoint SMS Voice, QLDB doesn't
support retry headers per their CORS config. So remove the support for
these service to unblock the browser usage
@AllanZhengYP AllanZhengYP merged commit fc98d2d into aws:master Dec 21, 2020
@github-actions
Copy link

github-actions bot commented Jan 8, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CORS requests now fail due to amz-sdk-invocation-id header
3 participants