-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(clients): remove retry headers for several services #1789
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1789 +/- ##
==========================================
- Coverage 79.77% 79.25% -0.53%
==========================================
Files 325 365 +40
Lines 12087 15072 +2985
Branches 2553 3206 +653
==========================================
+ Hits 9643 11945 +2302
- Misses 2444 3127 +683
Continue to review full report at Codecov.
|
...c/main/java/software/amazon/smithy/aws/typescript/codegen/AddOmitRetryHeadersDependency.java
Outdated
Show resolved
Hide resolved
98d4a7a
to
f8414a2
Compare
ConnectParticipant, IoT Data Plane, IoT, Pinpoint SMS Voice, QLDB doesn't support retry headers per their CORS config. So remove the support for these service to unblock the browser usage
f8414a2
to
7def35c
Compare
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
ConnectParticipant, IoT Data Plane, IoT, Pinpoint SMS Voice, QLDB doesn't
support retry headers per their CORS config. So remove the support for
these service to unblock the browser usage
Integration Test
request headers:
✅ ConnectParticipant
✅ IoT Data Plane
✅ IoT
✅ Pinpoint SMS Voice
✅ QLDB
Request header
Issue #, if available:
Fixes #1376
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.