Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readme): npm downloads tag #1870

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 6, 2021

Issue #, if available:
N/A

Description of changes:
fix(readme): npm downloads tag

Before

Screen Shot 2021-01-05 at 4 50 42 PM

After

Screen Shot 2021-01-05 at 4 50 31 PM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title chore(readme): use packageName.svg tag fix(readme): npm downloads tag Jan 6, 2021
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 4b5efb9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@AllanZhengYP
Copy link
Contributor

Should this be a docs, chore, instead of fix?

@trivikr
Copy link
Member Author

trivikr commented Jan 6, 2021

Should this be a docs, chore, instead of fix?

It can be any either docs or fix
I used fix, as it fixes an existing issue.

@trivikr trivikr merged commit 1f8baf3 into aws:master Jan 7, 2021
@trivikr trivikr deleted the update-downloads-badge branch January 7, 2021 20:03
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants