SignatureDoesNotMatch error when S3 key contains *

[TsvetanMilanov]

Describe the bug
When trying to get/put object with key which contains * (e.g. te*st) the S3 client throws SignatureDoesNotMatch error.

SDK version number
3.2.0

Is the issue in the browser/Node.js/ReactNative?
Node.js

Details of the browser/Node.js/ReactNative version
v12.16.1

To Reproduce (observed behavior)

const { S3 } = require("@aws-sdk/client-s3");

const s3 = new S3({ region: "us-east-1" });
await s3.putObject({ Bucket: "test-signature-sdk-v3", Key: "test*", Body: "test" });

Expected behavior
Expecting the method invocation to succeed, but it throws SignatureDoesNotMatch error.

Additional context
There is a similar issue #283 and a related fix #284. The S3 client works with : (e.g. te:st) but not with *. The aws-sdk v2 works correctly with key te*st

[ajredniwja]

Hey @TsvetanMilanov I was able to reproduce this issue, it is currently in our high priority list, the issue will be updated once it has been fixed.

[trivikr]

This happens because encodeURIComponent doesn't escape *.

Currently the additional encoding is only done in signer, and some additional characters will be required to be escaped

aws-sdk-js-v3/packages/signature-v4/src/SignatureV4.ts

Lines 280 to 283 in 906e4b0

	if (this.uriEscapePath) {
	const doubleEncoded = encodeURIComponent(path.replace(/^\//, ""));
	return `/${doubleEncoded.replace(/%2F/g, "/")}`;
	}

The solution would be to do additional encoding on top of encodeURIComponent output.
Code from v2: https://github.com/aws/aws-sdk-js/blob/dd83d672170e8cc0c52a20df29a43e7663e5336a/lib/util.js#L41-L46

[dobrynin]

Bump, can the suggest change be implemented?

[live680g]

This error is being exist.
"@aws-sdk/client-s3": "^3.142.0",

[dobrynin]

myString.replace("*", "%2A"); fixed for me.

[Dids]

This also happens when metadata contains special/unicode characters, such as ContentDisposition, which I've been wrestling with lately.

Using the latest SDK and specifically the CopyObjectCommand, as I'm trying to update metadata for a lot of files, as part of a migration to S3, however this has been a rather unpleasant surprise.

[yenfryherrerafeliz]

Hi @TsvetanMilanov, @Dids, @dobrynin, @live680g, this issue has been fixed. Please update to the latest version of the SDK you should have not issues.

If you folks have anything else that we can help with, please feel free of opening a new issue.

Thanks!

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.