-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use downlevel-dts to generate TS 3.4 compatible types #1943
Conversation
d8a08ca
to
33d6ddb
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
smithy-typescript PR smithy-lang/smithy-typescript#266 |
Quote my comment on the Smithy PR for record:
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue #, if available:
Fixes: #1919
Description of changes:
Use downlevel-dts to generate TS 3.4 compatible types.
Testing:
tsc
is successful while usingtypescript@3.7.5
in the repro code provided in Typescript 3.7.x breaking @aws-sdk/types #1919clients/client-dynamodb
packages/types
lib/storage
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.