-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(credential-provider-node): read config and credentials files only once #2045
fix(credential-provider-node): read config and credentials files only once #2045
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #2045 +/- ##
==========================================
+ Coverage 79.30% 79.36% +0.06%
==========================================
Files 368 368
Lines 15132 15210 +78
Branches 3222 3254 +32
==========================================
+ Hits 12001 12072 +71
- Misses 3131 3138 +7
Continue to review full report at Codecov.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Description
This change refactors node credential provider.
loadedConfig
parameters as internal to reduce the exposure of API.Additional context
These changes are required for new credential provider.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.